Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filterbar.sass: use the whole screen for .fulltab #80

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jbsilva
Copy link
Contributor

@jbsilva jbsilva commented Jul 7, 2024

This will make the gallery fill the whole screen

@mfg92
Copy link
Owner

mfg92 commented Jul 19, 2024

On my side, the gallery was already filling up the whole screen. Can you explain what problem you were trying to solve?

With your changes, I am unable to scroll through the gallery.

@jbsilva
Copy link
Contributor Author

jbsilva commented Jul 20, 2024

position: fixed is indeed wrong. I updated my PR.

But without min-width, the gallery was taking only a small part of the screen:

@mfg92
Copy link
Owner

mfg92 commented Jul 22, 2024

Ok, I was able to reproduce the problem you describe. This bug was hidden on my site due to the CSS of my theme.
Thanks for your contribution!

@mfg92 mfg92 merged commit 038e1bb into mfg92:master Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants